Skip to content

vmnet: Support offloading for krunkit #20831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

vmnet: Support offloading for krunkit #20831

merged 1 commit into from
Jun 30, 2025

Conversation

nirs
Copy link
Contributor

@nirs nirs commented May 24, 2025 •
edited
Loading

libkrun virtio-net driver enables TSO offloading and checksum offloading by default, so we must use vment-helper --enable-tso and --enable-checksum-offload with krunkit. These options do not work with vfkit.

This change is required for adding krunkit driver: #20803

Needed until this issue is resolved:
containers/libkrun#264

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nirs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nirs nirs mentioned this pull request May 24, 2025
Open
4 tasks
@nirs nirs force-pushed the vmnet-offloading branch from b805093 to dc308d7 Compare June 5, 2025 00:02
@nirs
Copy link
Contributor Author

nirs commented Jun 5, 2025

ok-to-test

@nirs
vmnet: Support offloading for krunkit
b634d8f 
libkrun virtio-net driver enables TSO offloading and checksum
offloading by default, so we must use vment-helper --enable-tso and
--enable-checksum-offload with krunkit. These options do not work with
vfkit.
@nirs nirs force-pushed the vmnet-offloading branch from dc308d7 to b634d8f Compare June 6, 2025 22:32
@nirs
Copy link
Contributor Author

nirs commented Jun 6, 2025

@medyagh this should be ready for merge, please add ok-to-test.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@medyagh
Copy link
Member

medyagh commented Jun 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20831) |
+----------------+----------+---------------------+
| minikube start | 51.4s    | 50.3s               |
| enable ingress | 16.1s    | 15.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.8s 52.3s 50.5s 50.9s 53.6s
Times for minikube (PR 20831) start: 50.4s 50.3s 50.1s 50.1s 50.4s

Times for minikube ingress: 19.5s 14.9s 15.5s 15.0s 15.4s
Times for minikube (PR 20831) ingress: 15.9s 16.0s 15.4s 15.0s 14.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20831) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 23.8s               |
| enable ingress | 12.6s    | 12.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 23.5s 23.0s 25.6s 21.4s
Times for minikube (PR 20831) start: 24.5s 25.3s 22.5s 22.7s 23.9s

Times for minikube ingress: 12.7s 12.3s 13.2s 13.8s 10.8s
Times for minikube (PR 20831) ingress: 12.3s 13.2s 13.3s 12.3s 13.3s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 20831) |
+-------------------+----------+---------------------+
| minikube start    | 23.8s    | 22.8s               |
| ⚠️  enable ingress | 26.3s    | 34.1s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 21.7s 24.0s 21.8s 26.1s 25.3s
Times for minikube (PR 20831) start: 24.2s 23.4s 22.6s 21.9s 22.0s

Times for minikube ingress: 40.3s 22.8s 22.7s 22.7s 22.8s
Times for minikube (PR 20831) ingress: 30.4s 22.8s 38.7s 38.8s 39.7s

@spowelljr spowelljr removed their request for review June 26, 2025 23:51
@nirs
Copy link
Contributor Author

nirs commented Jun 27, 2025

@medyagh can you merge?

@medyagh
Copy link
Member

medyagh commented Jun 30, 2025

/lgtm

@medyagh medyagh merged commit 804c01a into kubernetes:master Jun 30, 2025
26 of 40 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirs nirs deleted the vmnet-offloading branch July 2, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

Assignees

@medyagh medyagh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nirs @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot